Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename partial add/remove benchmarks #9868

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Rename partial add/remove benchmarks #9868

merged 2 commits into from
Aug 23, 2023

Conversation

dberenbaum
Copy link
Collaborator

Better naming for some benchmarks and fixes issues due to duplicate naming that cause plots like this:

visualization(10)

@dberenbaum dberenbaum requested a review from a team August 22, 2023 19:12
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.27% ⚠️

Comparison is base (cae1b1b) 90.82% compared to head (117655f) 90.56%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9868      +/-   ##
==========================================
- Coverage   90.82%   90.56%   -0.27%     
==========================================
  Files         471      471              
  Lines       35920    35921       +1     
  Branches     5194     5194              
==========================================
- Hits        32626    32532      -94     
- Misses       2710     2783      +73     
- Partials      584      606      +22     
Files Changed Coverage Δ
...testing/benchmarks/cli/stories/test_modify_data.py 0.00% <0.00%> (ø)

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 54 to 55
bench_dvc("add", dataset, name="noop")
bench_dvc("push", name="noop")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noop isn't the right word here for dvc add. Maybe update?

@skshetry skshetry merged commit fc955c1 into main Aug 23, 2023
17 of 18 checks passed
@skshetry skshetry deleted the partial-benchmark-names branch August 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants