Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout: Expose --allow-missing arg. #9919

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Sep 6, 2023

$ git clone https://github.com/iterative/example-get-started-experiments
$ cd example-get-started-experiments
$ dvc fetch models/model.pkl
$ dvc checkout
A       models/model.pkl
ERROR: Checkout failed for following targets:
data/pool_data
data/train_data
data/test_data
model.tar.gz
models/model.pth
results/evaluate/plots/images
Is your cache up to date?
<https://error.dvc.org/missing-files>
$ git clone https://github.com/iterative/example-get-started-experiments
$ cd example-get-started-experiments
$ dvc fetch models/model.pkl
$ dvc checkout --allow-missing
A       models/model.pkl

@daavoo daavoo added ui user interface / interaction A: data-management Related to dvc add/checkout/commit/move/remove labels Sep 6, 2023
@daavoo daavoo self-assigned this Sep 6, 2023
@daavoo daavoo requested a review from a team September 6, 2023 08:37
@daavoo
Copy link
Contributor Author

daavoo commented Sep 6, 2023

Just noticed, --allow-missing is too silent in the UI when nothing is found, it might be good to at least show the warning with the missing things even if we don't fail

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
tests/unit/command/test_checkout.py ø
dvc/commands/checkout.py 100.00%

📢 Thoughts on this report? Let us know!.

@dberenbaum
Copy link
Collaborator

Does it close #9917?

@daavoo daavoo enabled auto-merge (squash) September 7, 2023 09:33
@daavoo
Copy link
Contributor Author

daavoo commented Sep 7, 2023

Does it close #9917?

Not sure, there are other flags requested/suggested but maybe this one is enough

@daavoo daavoo merged commit 7fb8a9a into main Sep 7, 2023
21 checks passed
@daavoo daavoo deleted the checkout-allow-missing branch September 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: data-management Related to dvc add/checkout/commit/move/remove ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants