Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new callback to DVCLive #168

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Add new callback to DVCLive #168

merged 7 commits into from
Oct 4, 2021

Conversation

sirily
Copy link
Contributor

@sirily sirily commented Sep 30, 2021

Close #85

  • Added callback for pytorch lightning
  • Didn't update docs. I'll do it when you accept my changes. It's my first PR, so I'm not sure, that I'm doing it right Β―_(ツ)_/Β―

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sirily ! πŸš€

Just some minor changes required

dvclive/lightning.py Outdated Show resolved Hide resolved
dvclive/lightning.py Outdated Show resolved Hide resolved
dvclive/lightning.py Outdated Show resolved Hide resolved
dvclive/lightning.py Show resolved Hide resolved
dvclive/lightning.py Outdated Show resolved Hide resolved
@daavoo daavoo added the feature label Sep 30, 2021
sirily and others added 5 commits September 30, 2021 21:44
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
tests/test_lightning.py Outdated Show resolved Hide resolved
dvclive/lightning.py Outdated Show resolved Hide resolved
@sirily sirily requested a review from daavoo October 1, 2021 11:54
@sirily
Copy link
Contributor Author

sirily commented Oct 1, 2021

Created the issue about documentation update. I'll create a PR to dvc.org tomorrow

@daavoo daavoo merged commit 4f000f0 into iterative:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrations: pytorch lightning
2 participants