Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dvcx): Add DVCX parameters to ConfigMap #119

Merged
merged 9 commits into from
Jul 14, 2023
Merged

Conversation

mjasion
Copy link
Contributor

@mjasion mjasion commented Jul 13, 2023

No description provided.

@mjasion mjasion self-assigned this Jul 13, 2023
@mjasion mjasion marked this pull request as draft July 13, 2023 09:20
@mjasion mjasion changed the title feat(helm-chart): Add DQL parameters to ConfigMap feat(helm-chart): Add DVCX parameters to ConfigMap Jul 13, 2023
charts/studio/values.yaml Outdated Show resolved Hide resolved
omesser
omesser previously approved these changes Jul 13, 2023
@mjasion mjasion changed the title feat(helm-chart): Add DVCX parameters to ConfigMap feat(dvcx): Add DVCX parameters to ConfigMap Jul 13, 2023
@@ -27,6 +27,8 @@ maintainers:
- name: iterative
email: support@iterative.ai

icon: "https://static.iterative.ai/logo/studio.svg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjasion mjasion marked this pull request as ready for review July 13, 2023 14:23
@mjasion mjasion enabled auto-merge July 13, 2023 14:23
@mjasion mjasion requested a review from omesser July 13, 2023 15:15
Copy link
Contributor

@jesper7 jesper7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment

charts/studio/values.yaml Outdated Show resolved Hide resolved
jesper7
jesper7 previously approved these changes Jul 14, 2023
@mjasion mjasion added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 3f74159 Jul 14, 2023
@mjasion mjasion deleted the add_dql_parameters branch July 14, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants