-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dvcx): Add DVCX parameters to ConfigMap #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omesser
suggested changes
Jul 13, 2023
mjasion
force-pushed
the
add_dql_parameters
branch
from
July 13, 2023 09:36
1fdf5ab
to
3ebee91
Compare
mjasion
changed the title
feat(helm-chart): Add DQL parameters to ConfigMap
feat(helm-chart): Add DVCX parameters to ConfigMap
Jul 13, 2023
mjasion
force-pushed
the
add_dql_parameters
branch
from
July 13, 2023 12:06
9da6790
to
c31493e
Compare
omesser
reviewed
Jul 13, 2023
omesser
previously approved these changes
Jul 13, 2023
mjasion
changed the title
feat(helm-chart): Add DVCX parameters to ConfigMap
feat(dvcx): Add DVCX parameters to ConfigMap
Jul 13, 2023
mjasion
commented
Jul 13, 2023
@@ -27,6 +27,8 @@ maintainers: | |||
- name: iterative | |||
email: support@iterative.ai | |||
|
|||
icon: "https://static.iterative.ai/logo/studio.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mjasion
force-pushed
the
add_dql_parameters
branch
from
July 13, 2023 14:20
f2ebf2b
to
68c899d
Compare
jesper7
suggested changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment
jesper7
previously approved these changes
Jul 14, 2023
Co-authored-by: Oded Messer <odedmesser@gmail.com>
…worker configmaps
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
mjasion
force-pushed
the
add_dql_parameters
branch
from
July 14, 2023 10:25
664ae4f
to
e7df681
Compare
jesper7
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.