-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
I guess this is related to #233 ? If so cc @dberenbaum I'm not sure I'm getting this mlem declare2 syntax TBH. Maybe a bit more explanation or quick demo in the PR description? |
Made less dirty and added for other commands This breaks backward compatibility for some of them because of rearranged arguments ( |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # mlem/core/objects.py
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #363 +/- ##
================================================
Coverage ? 90.59%
================================================
Files ? 82
Lines ? 6856
Branches ? 0
================================================
Hits ? 6211
Misses ? 645
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
add server config into docker build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions and comments/ questions on about half of the files changed (other than tests). Please use what you need and generalize to the rest if possible 🙂
@jorgeorpinel we kinda need to merge this to unblock other PRs, I will address your feedback in a separate PR though |
Sure! Didn't mean to block. I noticed the PR was approved but sometimes there's still other feedback that can def. wait or be rejected. Up to you! |
I was investigating how we can add help to
-c
options. I was able to do this (but in a bit nasty way)You can check it out with
mlem declare2 env docker --help
. Should work with othermlem declare2
commands.I didnt add field types, defaults and support for complex/nested objects yet
cc @aguschin @jorgeorpinel @omesser
close #214
close #233
close #351