Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customcomplete.py example appears broken #42

Closed
johnw42 opened this issue Jul 19, 2021 · 0 comments · Fixed by #43
Closed

customcomplete.py example appears broken #42

johnw42 opened this issue Jul 19, 2021 · 0 comments · Fixed by #43
Assignees
Labels
documentation Markdown files enhancement New feature or request p0-critical Max priority (ASAP)

Comments

@johnw42
Copy link

johnw42 commented Jul 19, 2021

I see there's a variable called PREAMBLE that looks like it contains code to make the rest of the completion logic work, but it's not used anywhere. It looks like it was lost in commit 5c6a63a. It looks like the easiest fix would be to add a preamble argument to add_argument_to and arrange for its value to be passed through to complete.

@casperdcl casperdcl self-assigned this Jul 20, 2021
@casperdcl casperdcl added p0-critical Max priority (ASAP) documentation Markdown files labels Jul 20, 2021
casperdcl added a commit that referenced this issue Jul 20, 2021
@casperdcl casperdcl added enhancement New feature or request and removed documentation Markdown files labels Jul 20, 2021
@casperdcl casperdcl added the documentation Markdown files label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files enhancement New feature or request p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants