Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #89 #114

Merged
merged 4 commits into from
Apr 2, 2023
Merged

Fix #89 #114

merged 4 commits into from
Apr 2, 2023

Conversation

Freed-Wu
Copy link
Contributor

No description provided.

@sourcery-ai

This comment was marked as off-topic.

@casperdcl casperdcl self-requested a review October 29, 2022 14:55
@casperdcl casperdcl added enhancement New feature or request good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying external-request You asked, we did labels Oct 29, 2022
@Freed-Wu
Copy link
Contributor Author

Any other problem?

@Freed-Wu
Copy link
Contributor Author

@casperdcl ?

@casperdcl
Copy link
Collaborator

casperdcl commented Mar 30, 2023

Apologies for the delay; thanks for bumping, @Freed-Wu.

Added some tests.

Slightly concerned people may get confused (e.g. an FAQ might be "why does shtab --print-completion=bash mylib.get_parser print shtab's rather than mylib's completions?").

To help combat this, perhaps it's better to rename the option to --print-own-completion?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (1eb80f6) 91.36% compared to head (40413bb) 91.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   91.36%   91.39%   +0.02%     
==========================================
  Files           3        3              
  Lines         336      337       +1     
==========================================
+ Hits          307      308       +1     
  Misses         29       29              
Impacted Files Coverage Δ
shtab/main.py 87.50% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Freed-Wu
Copy link
Contributor Author

perhaps it's better to rename the option to --print-own-completion?

both are OK 😄

@casperdcl casperdcl merged commit 68ac169 into iterative:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants