String fmt - f-strings (almost) everywhere #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 91.39% 91.14% -0.26%
==========================================
Files 3 3
Lines 337 350 +13
==========================================
+ Hits 308 319 +11
- Misses 29 31 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
omesser
force-pushed
the
fstrings_galore
branch
3 times, most recently
from
bc6396f
to
400d2b9
Compare
omesser
force-pushed
the
fstrings_galore
branch
from
400d2b9
to
eaf00e2
Compare
omesser
changed the title
casperdcl
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... f-strings, f-stringss everywhere
Just a (hopefully...) non-functional PR - all for ✨ of using f-strings almost everywhere, except where it still doesn't make sense and
.format()is better way of keeping readability.This can be kinda opinionated, so let's see if maintainers (@0x2b3bfa0 and @casperdcl I guess?) feel the same way about the choices.