Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bash>=4.4 bad substitution #23

Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix bash>=4.4 bad substitution #23

merged 1 commit into from
Sep 30, 2020

Conversation

casperdcl
Copy link
Collaborator

@casperdcl casperdcl commented Sep 30, 2020

locally tested using docker bash:4.4.

Fixes this inconsistency:

x=a/b
echo ${!x}  # bash<=4.3: empty, >=4.4: error bad substitution

There's no real documentation about this change. Vaguely related links:

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files           1        1           
  Lines          38       38           
=======================================
  Hits           33       33           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5693b8...af45175. Read the comment docs.

@casperdcl casperdcl merged commit a01e2b5 into master Sep 30, 2020
@casperdcl casperdcl deleted the devel branch September 30, 2020 22:37
@casperdcl
Copy link
Collaborator Author

/tag v1.3.2

casperdcl added a commit to casperdcl/dvc that referenced this pull request Sep 30, 2020
Fixes bash>=4.4 completion.
See iterative/shtab#23
efiop pushed a commit to iterative/dvc that referenced this pull request Sep 30, 2020
Fixes bash>=4.4 completion.
See iterative/shtab#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-critical Max priority (ASAP) shell-bash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash>=4.4: bad substitution error on non-word characters
3 participants