Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential parser help str casting error #44

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix potential parser help str casting error #44

merged 1 commit into from
Jul 28, 2021

Conversation

casperdcl
Copy link
Collaborator

@casperdcl casperdcl commented Jul 20, 2021 •
edited
Loading

Sometimes add_argument(help=...) is not a string (but is castable to a string).

@casperdcl casperdcl added p0-critical Max priority (ASAP) shell-bash labels Jul 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #44 (195a640) into master (4731037) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files           3        3           
  Lines         210      210           
=======================================
  Hits          187      187           
  Misses         23       23
Impacted Files Coverage Δ
shtab/__init__.py 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4731037...195a640. Read the comment docs.

@casperdcl casperdcl changed the title fix potential parser str error fix potential parser help str casting error Jul 20, 2021
@casperdcl casperdcl self-assigned this Jul 21, 2021
@casperdcl casperdcl merged commit 5c414c4 into master Jul 28, 2021
@casperdcl casperdcl deleted the str-parser branch July 28, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
p0-critical Max priority (ASAP) shell-bash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx Completion Bug
2 participants
@casperdcl @codecov-commenter