-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix k8s tag propagation and controller-uid detection #656
Merged
0x2b3bfa0
merged 2 commits into
iterative:master
from
sjawhar:hotfix/k8s-task-id-selection
Sep 13, 2022
Merged
Fix k8s tag propagation and controller-uid detection #656
0x2b3bfa0
merged 2 commits into
iterative:master
from
sjawhar:hotfix/k8s-task-id-selection
Sep 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
0x2b3bfa0
added
bug
Something isn't working
technical-debt
Refactoring, linting & tidying
cloud-common
Applies to every cloud vendor
resource-task
iterative_task TF resource
cloud-k8s
Kubernetes
leo
standalone CLI binary
labels
Sep 5, 2022
0x2b3bfa0
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests are failing, can you please take a look?
0x2b3bfa0
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like smoke tests keep failing after retrying. 🤔
task_smoke_test.go:133:
Error Trace: task_smoke_test.go:133
Error: Received unexpected error:
container "tpi-smoke-test-2996915558-5wp6qvfp-4rg3ne32" in pod "tpi-smoke-test-2996915558-5wp6qvfp-4rg3ne32-sxj56" is not available
Test: TestTaskSmoke/k8s
Finally tests are passing! 😅 |
0x2b3bfa0
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
cloud-common
Applies to every cloud vendor
cloud-k8s
Kubernetes
leo
standalone CLI binary
resource-task
iterative_task TF resource
technical-debt
Refactoring, linting & tidying
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Task
object (where they are always empty) instead of the correctCloud
object.ObjectMeta
, which then breaks things like waiting for the job to be created, etc.Approach
Cloud
Spec.Selector.MatchLabels
instead ofObjectMeta
to retrievecontroller-uid
Logs
This is what
kubectl describe job
shows on master:Without custom labels/tags:
With labels: