Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that 'portrait' is not the only orientation on Chrome for Android in manifest.json #37

Closed
wants to merge 3 commits into from

Conversation

euangoddard
Copy link

Supports null, 'portrait' and 'landscape'

@haydenbleasel
Copy link
Contributor

Need to add the property to data/defaults.json and document it in the readme.md.

@euangoddard
Copy link
Author

OK. I'll take a look at that when I get a chance. Do you see any merit in allowing overrides for all the of properties which are generated in manifest.json?

@haydenbleasel
Copy link
Contributor

The RFG docs state the following for orientation:

When present and display is standalone, force the screen to a particular orientation. Either portrait or landscape.

And the following for display:

browser (the site is opened like any regular bookmark, in a new Chrome tab. Because Android Chrome does not actually support the browser attribute, the display attribute is completely absent of the generated manifest) or standalone (the web site is somehow treated like a native application. When the home screen link is clicked, a new Chrome instance is opened, the navigation UI is not displayed and the web site is displayed full-screen).

I'm not sure null default values apply - maybe standalone / portrait?

@@ -31,7 +31,9 @@
"silhouette": false,
"version": 1.0,
"config": null,
"logging": false
"logging": false,
"androidOrientation": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be "portrait"

@haydenbleasel haydenbleasel mentioned this pull request Nov 3, 2015
19 tasks
@haydenbleasel
Copy link
Contributor

Hey @euangoddard, merging this issue into Favicons 4.0. I'd love for you to join in the discussion: #51

@euangoddard
Copy link
Author

Will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants