Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): switch out from latest versions in dependencies #465

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

wszydlak
Copy link
Contributor

@wszydlak wszydlak commented Jul 27, 2021

fixes #464

Summary

Due to uncontrolled updates of third party dependencies used by webfont i've prepared this PR to switch out from latest versions in dependencies section in package.json.
Using latest versions is very risky and may break webfont at any time (which happend in #464)

Proposed changes

This PR brings the following changes:

  • Update dependencies to use specified by semver range versions
  • Upgrade svgicons2svgfont
  • Update hashes in tests

Related issue

#464

Dependencies added/removed (if applicable)

  • svgicons2svgfont (update patch)
  • svg2ttf (update major)

Testing

  • I have added or updated tests that prove my fix is effective or that my feature works (if applicable)
    • Unit tests (updated hashes)

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...);
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes;
  • I have made changes to the documentation (if applicable);
  • My changes generate no new warnings or errors;

@wszydlak wszydlak mentioned this pull request Jul 27, 2021
Copy link
Collaborator

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyandrade jimmyandrade added the dependencies Pull requests that update a dependency file label Jul 27, 2021
@jimmyandrade jimmyandrade self-assigned this Jul 27, 2021
@jimmyandrade jimmyandrade merged commit 821cb02 into itgalaxy:master Jul 27, 2021
@jimmyandrade
Copy link
Collaborator

@wszydlak thank you so much.

webfont@11.2.17 released at npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globby now uses ESM
2 participants