-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pharos): add layout component #17
Conversation
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
🦋 Changeset detectedLatest commit: 41151ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think I enjoy the DX of this. This component feels geared pretty specifically toward page-level layouts, and as such I wonder if it might be better to name it <pharos-layout>
or similar to avoid conveying that it should be used for granular gridding needs.
packages/pharos/src/pages/item-detail/react/item-detail.pages.stories.tsx
Outdated
Show resolved
Hide resolved
Yeah |
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
packages/pharos/src/components/layout/PharosLayout.react.stories.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dane Hillard <dane.hillard@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Add a layout component for our various page layouts used on the platform. The three layouts include:
1 column
: margins range from 1.25rem to 9rem with fixed-width content1 column w/sidenav
: margin is 1.5rem on mobile, otherwise 3.5rem with fluid content2 column
: margin is 1.5rem on mobile, otherwise 3.5rem with fluid contentThe layouts should support our defined breakpoints:
small
: 360pxmedium
: 768pxlarge
: 1056pxxlarge
: 1360pxmax
: 1584pxHow does this change work?
Additional context
CSS variables cannot currently be used for media queries so I opted to use the Sass tokens.