Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: improve imports #433

Merged
merged 6 commits into from Oct 29, 2022
Merged

Site: improve imports #433

merged 6 commits into from Oct 29, 2022

Conversation

daneah
Copy link
Member

@daneah daneah commented Oct 29, 2022

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

Resolves #182

Improve imports in the pharos-site package so they don't have several levels of relative importing.

How does this change work?

Use gatsby-plugin-alias-imports to easily configure the underlying webpack configuration for path aliases.

Additional context

  • Update a few other tangential dependencies to make the build work more properly.
  • Update the version in .tool-versions to the latest version of Node 16

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2022

🦋 Changeset detected

Latest commit: e46ce16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos-site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@daneah daneah changed the title Chore/improve imports Site: improve imports Oct 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2022

size-limit report 📦

Path Size
packages/pharos/lib/index.js 48.31 KB (-0.16% 🔽)

@daneah daneah merged commit 67fba0f into develop Oct 29, 2022
@daneah daneah deleted the chore/improve-imports branch October 29, 2022 19:30
daneah added a commit that referenced this pull request Nov 10, 2022
* develop:
  Tabs: fix initial tab selection in more cases (#449)
  Storybook: add eslint-plugin-storybook and fix issues (#446)
  feat(storybook): install Measure and Outline addons (#445)
  Docs: update copy for Button's on-background usage (#444)
  Storybook: Convert stories to CSF 3 (#435)
  feat(tabs): fire event when tab selected programmatically (#442)
  ToggleButton: indicate toggle button state on underlying button elements (#438)
  Tooltip, DropdownMenu: replace popperjs with floating-ui (#434)
  Site: improve imports (#433)
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
* chore(site): improve imports

* chore: add changeset

* fix: correct registry in yarn.lock

* fix: correct TLD in yarn.lock

* Trigger new build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site: Use aliases to clean up guidelines imports
2 participants