Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update copy for Button's on-background usage #444

Merged
merged 3 commits into from Nov 7, 2022

Conversation

daneah
Copy link
Member

@daneah daneah commented Nov 7, 2022

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

Fixes #383

How does this change work?

Replace accidentally duplicated copy with copy suggested in filed issue.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

🦋 Changeset detected

Latest commit: ac3214b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos-site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@daneah daneah changed the title fix(docs): update copy for Button's on-background usage Docs: update copy for Button's on-background usage Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

size-limit report 📦

Path Size
packages/pharos/lib/index.js 46.46 KB (0%)

@daneah daneah merged commit 237339f into develop Nov 7, 2022
@daneah daneah deleted the fix/button-on-background-copy branch November 7, 2022 23:31
daneah added a commit that referenced this pull request Nov 10, 2022
* develop:
  Tabs: fix initial tab selection in more cases (#449)
  Storybook: add eslint-plugin-storybook and fix issues (#446)
  feat(storybook): install Measure and Outline addons (#445)
  Docs: update copy for Button's on-background usage (#444)
  Storybook: Convert stories to CSF 3 (#435)
  feat(tabs): fire event when tab selected programmatically (#442)
  ToggleButton: indicate toggle button state on underlying button elements (#438)
  Tooltip, DropdownMenu: replace popperjs with floating-ui (#434)
  Site: improve imports (#433)
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
* fix(docs): update copy for Button's on-background usage

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: Add onBackground variant documentation on pharos.jstor.org
3 participants