Storybook: add eslint-plugin-storybook and fix issues #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
daneah
commented
Nov 8, 2022
Comment on lines
+16
to
+18
| babelOptions: { | ||
| presets: ['@babel/preset-react'], | ||
| }, |
There was a problem hiding this comment.
This was a necessary addition to get JSX playing nicely; the ecmaFeatures: { jsx: true } } wasn't sufficient on its own.
| @@ -21,6 +29,7 @@ module.exports = { | |||
| }, | |||
| rules: { | |||
| 'no-smart-quotes/no-smart-quotes': 'error', | |||
| 'react/react-in-jsx-scope': 'off', | |||
daneah
requested review from
chrisjbrown,
SMQuazi and
satya-achanta-venkata
and removed request for
a team
chrisjbrown
approved these changes
Nov 8, 2022
- Fix style attributes that were strings instead of objects - Fix misconfigured `docs` meta property
daneah
added a commit
that referenced
this pull request
Nov 10, 2022
* develop: Tabs: fix initial tab selection in more cases (#449) Storybook: add eslint-plugin-storybook and fix issues (#446) feat(storybook): install Measure and Outline addons (#445) Docs: update copy for Button's on-background usage (#444) Storybook: Convert stories to CSF 3 (#435) feat(tabs): fire event when tab selected programmatically (#442) ToggleButton: indicate toggle button state on underlying button elements (#438) Tooltip, DropdownMenu: replace popperjs with floating-ui (#434) Site: improve imports (#433)
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* feat(storybook): add eslint-plugin-storybook and fix issues * fix(storybook): remove unused args from story signatures * fix(storybook): remove previously ignored linting issues * fix(storybook): fix missing and erroring React stories - Fix style attributes that were strings instead of objects - Fix misconfigured `docs` meta property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Resolves #286
How does this change work?
Additional context
This is currently at odds with storybookjs/storybook#13362 because removing the unused argument to the
renderfunction in the React stories causes the Docs tab to show No code available for each example. The web components Storybook doesn't suffer from this issue.