Tooltip, DropdownMenu: replace popperjs with floating-ui #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daneah
requested review from
SMQuazi,
jialin-he and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: b7452d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
daneah
changed the title
size-limit report 📦
|
jialin-he
approved these changes
Oct 31, 2022
|
|
|
@Niznikr Thanks for the clue—I did notice that but I had hoped they wouldn't interplay. Maybe my understanding of hoisting is a bit poor 😅 I'm interested nonetheless in reproducing locally—will try from a totally fresh install and see what happens. |
satya-achanta-venkata
approved these changes
Oct 31, 2022
daneah
added a commit
that referenced
this pull request
Nov 10, 2022
* develop: Tabs: fix initial tab selection in more cases (#449) Storybook: add eslint-plugin-storybook and fix issues (#446) feat(storybook): install Measure and Outline addons (#445) Docs: update copy for Button's on-background usage (#444) Storybook: Convert stories to CSF 3 (#435) feat(tabs): fire event when tab selected programmatically (#442) ToggleButton: indicate toggle button state on underlying button elements (#438) Tooltip, DropdownMenu: replace popperjs with floating-ui (#434) Site: improve imports (#433)
Merged
12 tasks
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* chore(tooltip, dropdown-menu): replace popperjs with floating-ui * chore: add debug logging to GitHub Actions * chore: remove debug logging from GitHub Actions * chore: add changeset * fix(ci): update set-output to environment files Closes ithaka#436 * chore(ci): update actions/cache from v2 to v3 * chore(ci): update actions/checkout and actions/setup-node from v2 to v3 * fix(styles): fix stylelint errors around specificity * fix(toggle-button): fix border width regression on hover * fix(toggle-button): fix style regression and story display * fix(tooltip, dropdown-menu): remove contain property * fix(storybook): fix poor prettier transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Resolves #266
Closes #436
How does this change work?
Replace usage and management of PopperJS with Floating UI, largely by following the documentation.
Additional context
'auto'placements and fallbacks, opting instead to have a'bestFit'option for fallback strategy which is now the default. This means we should deprecate the use of'auto'for consumers moving forward. For now I've opted to have'auto'get removed fromfallbackPlacementsif supplied, and to be switched to'top'if supplied as the main placement.