Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the missing href value #508

Closed
wants to merge 1 commit into from
Closed

Update the missing href value #508

wants to merge 1 commit into from

Conversation

Yasir761
Copy link

@Yasir761 Yasir761 commented Apr 1, 2023

This change: (check at least one)

fixes #507

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
A clear and concise description or a direct link to an issue [e.g. #15]
If adding a feature, a rationale for its addition goes here.

How does this change work?
A clear, detailed description of how this change addresses the issue.
This could be a bullet list if there are several moving parts.

Additional context
Add any other context here.

@Yasir761 Yasir761 requested a review from a team as a code owner April 1, 2023 10:59
@Yasir761 Yasir761 requested review from chrisjbrown, daneah and satya-achanta-venkata and removed request for a team April 1, 2023 10:59
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023

⚠️ No Changeset found

Latest commit: 724b1f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@daneah daneah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yasir761 thank you for contributing! The issue you're referencing is actually a problem only with the site and the example components rendered there, rather than an issue with the component itself. The component should not change, here—just the props being supplied to it in the example on the site!

@daneah
Copy link
Member

daneah commented Apr 5, 2023

@Yasir761 are you planning to address the requested changes?

@Yasir761
Copy link
Author

thank you for contributing! The issue you're referencing is actually a problem only with the site and the example components rendered there, rather than an issue with the component itself. The component should not change, here—just the props being supplied to it in the example on the site!

Yes, I'm not able to find the prop where I can pass it.

Also, sorry for being late reply.

@daneah
Copy link
Member

daneah commented Apr 10, 2023

@Yasir761 No worries, thanks for responding—I think this is probably the place where the change is needed, corresponding to the page in the issue description! Let us know if you run into more challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site: Example Link renders as a button due to missing href
2 participants