Sidenav: Update wait for animation to be less flaky in test #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daneah
requested review from
chrisjbrown,
SMQuazi and
mtorres3
and removed request for
a team
|
daneah
changed the title
size-limit report 📦
|
|
I saw failures at each of 1ms and 100ms, but at 1000ms I've run the tests thrice and seen ✅ all the way through. |
mtorres3
approved these changes
May 26, 2023
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* fix(tests): update wait for sidenav animation to be less flaky * fix(test): update timeout to 100ms * fix(tests): try 1000ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Upon reviewing several of the flaky runs of unit tests, the
resets its slide status when going back to a viewport above 1055pxwas the frequent culprit. I suspect this is because the animation doesn't finish after the next frame much of the time, so usingaTimeoutto wait instead might be more robust. We useaTimeoutregularly throughout the tests. We can increase the timeout value if we continue to see flakiness out of it.How does this change work?
Replace
await nextFrame()withawait aTimeout(1000)in the flaky test.