Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: Add closed captions icons #561

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Conversation

mariadevadoss
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Adds closed captions icon

How does this change work?
Adds closed captions on and off icons

@mariadevadoss mariadevadoss requested a review from a team as a code owner July 13, 2023 20:47
@mariadevadoss mariadevadoss requested review from chrisjbrown, mtorres3 and satya-achanta-venkata and removed request for a team July 13, 2023 20:47
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 7270b56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

size-limit report 📦

Path Size
packages/pharos/lib/index.js 47.05 KB (-0.01% 🔽)

@jialin-he jialin-he merged commit c18e46a into develop Jul 14, 2023
@jialin-he jialin-he deleted the feature/add-closed-caption-icons branch July 14, 2023 15:17
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
* feat(icons): add closed captions icons

* docs(icons): update change log for adding closed captions icons

* feat(icons): add closed captions on and off icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants