DropdownMenu: add onBackground variant #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialin-he
requested review from
SMQuazi,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: d11834a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
michael-iden
reviewed
Aug 3, 2023
michael-iden
approved these changes
Aug 3, 2023
…/pharos into feature/onbackground-menu
daneah
reviewed
Aug 3, 2023
Comment on lines
+183
to
+190
| const effect = () => { | ||
| useEffect(() => { | ||
| setTimeout(() => { | ||
| document.querySelector('#my-button-on-background').click(); | ||
| }, 700); | ||
| }); | ||
| }; | ||
| effect(); |
There was a problem hiding this comment.
I think Storybook might have nicer APIs for doing things like this now...something for later since I see you're borrowing an existing pattern, unless you're so inclined to update the stories in at least this file to use it.
packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx
Show resolved
Hide resolved
SMQuazi
approved these changes
Aug 4, 2023
daneah
reviewed
Aug 7, 2023
packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu-item.scss
Outdated
Show resolved
Hide resolved
…enu-item.scss Co-authored-by: Dane Hillard <github@danehillard.com>
daneah
reviewed
Aug 8, 2023
packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx
Outdated
Show resolved
Hide resolved
packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx
Outdated
Show resolved
Hide resolved
Merged
daneah
added a commit
that referenced
this pull request
Aug 20, 2023
daneah
changed the title
daneah
changed the title
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* feat(color): add new color * feat(menu-item): add on background variant * feat(menu): add on background variant * feat(menu): do not show stroke on on background menu * docs(changeset): change to minor version * feat(menu): update react story book * feat(menu): remove border for on background menu but add radius * Update packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu-item.scss Co-authored-by: Dane Hillard <github@danehillard.com> * feat(menu): add disabled state for onbackground menu * feat(menu): update story book * Update packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx * Update packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx --------- Co-authored-by: Mike Iden <mike.iden@ithaka.org> Co-authored-by: Dane Hillard <github@danehillard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Create an on-background version of menu.
How does this change work?
Pass the on-background property to the menu items when rendering them.