Infra: update Yarn scripts #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary extract-storybook scripts; they are deprecated and breaking the deployed builds. Adding the `storyStoreV7` feature back into the config accomplishes the same task - Visually separate groups of scripts for easier locating - Group the WC and React scripts together - Rename the scripts to more consistent names; **take note of these** - Add `watch:tsc` to the dev scripts so that component file changes reflect immediately in Storybook while developing Also bumped dependencies
daneah
requested review from
brentswisher,
SMQuazi and
mtorres3
and removed request for
a team
|
size-limit report 📦
|
brentswisher
approved these changes
Aug 7, 2023
This was referenced Aug 12, 2023
daneah
added a commit
that referenced
this pull request
Aug 20, 2023
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* fix(infra): update Yarn scripts - Remove unnecessary extract-storybook scripts; they are deprecated and breaking the deployed builds. Adding the `storyStoreV7` feature back into the config accomplishes the same task - Visually separate groups of scripts for easier locating - Group the WC and React scripts together - Rename the scripts to more consistent names; **take note of these** - Add `watch:tsc` to the dev scripts so that component file changes reflect immediately in Storybook while developing Also bumped dependencies * chore(infra): refresh yarn.lock * fix(infra): update Chromatic workflow command * fix(infra): update babel plugin name * fix(lint): update TS syntax * Revert "chore(infra): refresh yarn.lock" This reverts commit 4bd67ec. * fix(infra): revert and fix deps and config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
The Netlify build for the deployed Storybooks is currently failing.
@jialin-he also recently noted that changing component files locally was a chore because Storybook wasn't automatically reflecting those changes and required restarting it each time.
How does this change work?
storyStoreV7feature back into the config accomplishes the same goal, which is to end up with astories.jsonfile that can be used in the composed Storybookwatch:tscto the dev scripts so that component file changes reflect immediately in Storybook while developingAdditional context
Also bumped Storybook dependencies