Icon: Update stories to correctly pass description to components #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stories have a description argument but it was not actually being passed to the story components
brentswisher
requested review from
SMQuazi,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: 97dac28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
satya-achanta-venkata
approved these changes
Aug 4, 2023
daneah
changed the title
daneah
approved these changes
Aug 4, 2023
mtorres3
approved these changes
Aug 4, 2023
Merged
daneah
added a commit
that referenced
this pull request
Aug 20, 2023
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
…aka#577) * fix(icon): pass description correctly to stories The stories have a description argument but it was not actually being passed to the story components * chore(icon): add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PharosIcon stories currently have a description argument but it was not actually being passed to the story components, so it is not rendered into the stories. This fixes that.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
While working on #467 a group of pharos maintainers discovered that the current icon Storybook stories were broken, and decided to fix them before continuing.
How does this change work?
Correctly passes the description arguments to the story components