You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
Test suite(s) passing?
Code coverage maximal?
Changeset added?
Component status page up to date?
What does this change address?
I added this in #579 hoping it would automatically watch TypeScript files when running Storybook locally, but unfortunately this seems to interfere with certain things like the loading of icons.
How does this change work?
You can achieve this yourself by running e.g. yarn storybook:wc:dev and yarn watch:tsc in separate processes.
I added this hoping it would automatically watch TypeScript files when
running Storybook locally, but unfortunately this seems to interfere
with certain things like the loading of icons. You can achieve this
yourself by running e.g. `yarn storybook:wc:dev` and `yarn watch:tsc` in
separate processes.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@SMQuazi&& doesn't work because the commands involved don't complete, and the reason concurrently doesn't work here is maybe not something I understand well but my sense is that it's an order-of-operations thing between yarn watch:tsc and yarn watch:styles. It's possible wait-on might do something useful, but because it's currently broken and requires just the two commands to achieve the desired effect I want to at least ship this and maybe we can open an issue to look at that!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daneah
requested review from
SMQuazi,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
I added this in #579 hoping it would automatically watch TypeScript files when running Storybook locally, but unfortunately this seems to interfere with certain things like the loading of icons.
How does this change work?
You can achieve this yourself by running e.g.
yarn storybook:wc:devandyarn watch:tscin separate processes.