Card: Improve accessibility by moving overlay slot outside of <a> tag #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t can contain a clickable element
ymouzakis
requested review from
sirrah-tam,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: f5b49e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
sirrah-tam
approved these changes
Jun 12, 2024
packages/pharos/src/components/image-card/pharos-image-card.wc.stories.jsx
Show resolved
Hide resolved
|
@ymouzakis can you please update the PR description? Some information is missing and it seems like your commit message may have been truncated at the top there. |
jialin-he
approved these changes
Jun 13, 2024
michael-iden
approved these changes
Jun 14, 2024
mtorres3
approved these changes
Jun 14, 2024
mariadevadoss
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes a problem where the button inside of the overlay slot would not be picked up by the browser when tabbing through clickable elements. I believe this is because the button within the overlay was slotted inside of an anchor tag
How does this change work?
Move overlay slot outside of the link tag
Additional context
Add any other context here.