Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lit 3 and latest scoped element packages #791

Closed
wants to merge 3 commits into from

Conversation

daneah
Copy link
Member

@daneah daneah commented Jul 25, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

How does this change work?

  • Upgrade to Lit 3
  • Upgrade @lit-labs/scoped-registry-mixin
  • Upgrade @webcomponents/scoped-custom-element-registry
  • Update unit tests to pass, keeping their functional spirit

Additional context

This upgrade altered two things, as exposed by the unit tests:

  • Chrome no longer appears to fire an element's click handler if it has the disabled attribute
  • Webkit no longer seems to include underlying native elements in the composedPath for focusin

@daneah daneah added ithaka/pharos dependencies Pull requests that update a dependency file labels Jul 25, 2024
@daneah daneah requested a review from a team as a code owner July 25, 2024 02:26
@daneah daneah requested review from sirrah-tam, michael-iden and mtorres3 and removed request for a team July 25, 2024 02:26
Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: 77c63fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 25, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 63.95 KB (-1.08% 🔽)

@daneah
Copy link
Member Author

daneah commented Jul 25, 2024

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.

@sirrah-tam
Copy link
Contributor

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.

Oop, yep you are correct, there is some weirdness with how things are rendered in Storybook right now. Probs shouldn't have approved that 🙃
Screenshot 2024-07-25 at 11 33 06 AM

@michael-iden michael-iden self-requested a review July 29, 2024 17:07
@daneah daneah marked this pull request as draft July 30, 2024 12:00
@daneah
Copy link
Member Author

daneah commented Aug 2, 2024

There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly.

@Niznikr any chance you've run into this? I'm about at wit's end trying different things here 😓

@Niznikr
Copy link
Collaborator

Niznikr commented Aug 2, 2024

It might be an issue with Storybook as the issue reporter also seems to be using Lit 3 and the symptoms seem similar. storybookjs/storybook#28634

@daneah
Copy link
Member Author

daneah commented Aug 2, 2024

@Niznikr thanks for the link—had been looking around a bit in their issues but missed that one. It's a slightly different manifestation, but agreed that it might reveal a deeper issue. Will keep picking at it a bit, and maybe file a separate issue. Probably good to try a very small repro from scratch using the latest Lit and Storybook I suppose 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ithaka/pharos status/not ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get on latest scoped web component-related dependencies Upgrade to Lit 3
4 participants