-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Lit 3 and latest scoped element packages #791
Conversation
🦋 Changeset detectedLatest commit: 77c63fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow. |
@Niznikr any chance you've run into this? I'm about at wit's end trying different things here 😓 |
It might be an issue with Storybook as the issue reporter also seems to be using Lit 3 and the symptoms seem similar. storybookjs/storybook#28634 |
@Niznikr thanks for the link—had been looking around a bit in their issues but missed that one. It's a slightly different manifestation, but agreed that it might reveal a deeper issue. Will keep picking at it a bit, and maybe file a separate issue. Probably good to try a very small repro from scratch using the latest Lit and Storybook I suppose 😄 |
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
How does this change work?
@lit-labs/scoped-registry-mixin
@webcomponents/scoped-custom-element-registry
Additional context
This upgrade altered two things, as exposed by the unit tests:
click
handler if it has thedisabled
attributecomposedPath
forfocusin