Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace element content needs trimming #56

Closed
christian-schlichtherle opened this issue Sep 15, 2020 · 2 comments
Closed

namespace element content needs trimming #56

christian-schlichtherle opened this issue Sep 15, 2020 · 2 comments
Milestone
1.4.0

Comments

@christian-schlichtherle
Copy link
Contributor

First of all, thanks for this awesome project!

I think I found a bug in the scenarios.xml processing. The following works:

    <namespace prefix="ram">urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100</namespace>

However, the following results in a mismatch:

    <namespace prefix="ram">urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100
    </namespace>

I guess the element content needs trimming. I haven't tested where else in the XML this would break.
@apenski
Copy link
Collaborator

apenski commented Sep 16, 2020

yes, the missing trim causes errors. I'll fix this for the next release

rkottmann pushed a commit that referenced this issue Oct 2, 2020
@apenski
#56 trim namespaces and other strings when reading the scenarios
ef1ce56
@apenski apenski added this to the 1.3.2 milestone Oct 2, 2020
@apenski
Copy link
Collaborator

apenski commented Oct 2, 2020

fixed in master

@apenski apenski closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@christian-schlichtherle @apenski