Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches #13

Closed
olls opened this issue Nov 13, 2014 · 5 comments
Closed

Branches #13

olls opened this issue Nov 13, 2014 · 5 comments

Comments

@olls
Copy link
Member

olls commented Nov 13, 2014

Following from this.

For repositories where we don't want the master branch to be pushed live, but another one. We need a way of specifying which branch to use. This could be done by specifying the branch name in the webhook URL, eg: http://git.dvbris.com/[branch-name]. (This would be easier once we've moved the secret out of the URL, #11)

Then github-listener can pass this branch name on to the github-getter (descendant of run.sh) which will get the correct branch.

@olls
Copy link
Member Author

olls commented Nov 13, 2014

This should probably be used.

@geraintwhite
Copy link
Member

Why? We can just use url.parse and have the branch as a query string.

@olls
Copy link
Member Author

olls commented Nov 14, 2014

But would be neater to have the branch in the path

On Fri, 14 Nov 2014 08:35 Geraint White notifications@github.com wrote:

Why? We can just use url.parse and have the branch as a query string.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@geraintwhite
Copy link
Member

That can still be done with URL.parse

On Fri, 14 Nov 2014 08:44 Oliver Faircliff notifications@github.com wrote:

But would be neater to have the branch in the path

On Fri, 14 Nov 2014 08:35 Geraint White notifications@github.com wrote:

Why? We can just use url.parse and have the branch as a query string.


Reply to this email directly or view it on GitHub
<
https://github.com/itsapi/github-listener/issues/13#issuecomment-63024524>

.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@geraintwhite
Copy link
Member

Added support in github-listener fba21b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants