This repository has been archived by the owner on Apr 14, 2020. It is now read-only.
Composable animations #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2018
Closed
Refactors internals to enable a composable api for animations, this also introduces two new animations "Reveal" and "FadeMove", which are both used in "RevealMove" and "CrossFadeMove".
itsdouges
force-pushed
the
composable-animations
branch
from
30abcc0
to
f6a440e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new composable animations API, still WIP! Closes #74.
Internally when setting styles you'll instead have a callback function instead of returning styles straight
animate: AnimationCallback = (data, onFinish, setTargetProps) => { setTargetProps({ - style: { display: 'none' }, + style: (prevStyles) => ({ ...prevStyles, display: 'none' }), }); };As a side, also thinking about removing
classNamefrom animations internally and pumping style through emotion. That would end up making styles be fully CSS instead of inline styles. Will do in another PR though as it would be a breaking change for some consumers.TODO: