Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add settled fund to account information" #34

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

cnMuggle
Copy link
Contributor

@cnMuggle cnMuggle commented Jan 1, 2024

Reverts #24

not compatible with get_account_info_v2

I have tried simply adding 'account["totals"]["SettledFunds"],' or 'account["totals"]["settledFunds"],' in schwab.py.
Both doesn't work.

Sorry, I am not good at web page side. So I really don't have the skill to find out what's the correct key word.

image

@itsjafer itsjafer merged commit d817e6c into itsjafer:main Jan 1, 2024
@cnMuggle
Copy link
Contributor Author

cnMuggle commented Jan 2, 2024

@QingqiLei sorry to revert this. But it looks like more test for v2 of this keyword is needed.
The impact of not using settled fund is attached.

['Caution: This buy order was accepted without sufficient settled funds to trade in your account. If you subsequently sell this security without first delivering sufficient cash by settlement date, you may incur a trading restriction requiring settled cash up front for future purchases. (AC176)']

image

@cnMuggle
Copy link
Contributor Author

cnMuggle commented Jan 3, 2024

The impact of this shows up. For document purpose, I put the info below.

schwab order failed. ['Caution: This buy order was accepted without sufficient settled funds to trade in your account. If you subsequently sell this security without first delivering sufficient cash by settlement date, you may incur a trading restriction requiring settled cash up front for future purchases. (AC176)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants