Add API to fetch account transaction history #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjafer
reviewed
Jan 12, 2024
schwab_api/schwab.py
Outdated
| @@ -77,6 +77,44 @@ def get_account_info(self): | |||
|
|
|||
| return account_info | |||
|
|
|||
| def get_transaction_history(self, account_id): | |||
There was a problem hiding this comment.
Could we rename this get_transaction_history_v2(), for consistency with all other methods that are calling the "new" schwab API endpoints?
taylorconor
force-pushed
the
transaction-history
branch
from
5a729f4
to
5a2cdf4
Compare
itsjafer
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
schwab.get_transaction_history(account_id), which returns an object containing the full transaction history for the provided account ID.