Adding option strategies support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to include option chains
Included pandas in requirements.txt
itsjafer
reviewed
Mar 1, 2024
|
I made the requested changes. I like the idea of class-wide enumerators for the different option strategies or order types. I'm not totally sure on the best approach. I'd like to get the current pull request approved as is for now. It's probably only one of more pull requests to come. With options, I have a big question mark around handling option assignments before expiration. I saw that account positions have child positions. I wonder if that's where those will be referenced at. I hate that Schwab doesn't come with a paper trading account to figure this out. |
itsjafer
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending functionalities to enable option trading strategies supported by Schwabs.
Adding to the Schwab class:
Also included an example file that pulls the option chains, helps normalize the json response into a pandas dataframe and creates a dry run on an option straddle strategy.