Async #50
Closed
Async #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a huge fan of how adding this functionality kills the readability of this code. I'd like to find a solution that doesn't require code duplication and branching code paths. The TikTokApi, which similarly uses Playwright under the hood recommended using https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.run_in_executor for async users before they fully migrated to async. My preference would be to do a full migration (if that makes sense), rather than support partially support both |
|
Ok. Closing this pull request then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding asynchonous login option.