fix: compatibility with types/react 18.2.22 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
========================================
+ Coverage 2.73% 2.75% +0.01%
========================================
Files 45 45
Lines 2811 2796 -15
Branches 58 58
========================================
Hits 77 77
+ Misses 2690 2675 -15
Partials 44 44
☔ View full report in Codecov by Sentry. |
itsjavi
added
update-deps
jrson83
reviewed
Sep 24, 2023
| // globals: Story<P>['globals'] | ||
| parameters: Story<P>['parameters'] | ||
| story: BaseStory<F> & { id: string; component: F } | ||
| args: Story<F>['args'] |
There was a problem hiding this comment.
If a component has no props at all e.g.:
export default function Form() {}It throws two type errors:
src/form/form.stories.tsx:16:12 - error TS2322: Type 'unknown' is not assignable to type 'IntrinsicAttributes'.
16 <Story {...context?.args} />
src/form/form.stories.tsx:16:22 - error TS2698: Spread types may only be created from object types.
16 <Story {...context?.args} />This workaround fixes the issue currently:
export type FormProps = React.ComponentProps<'form'>
export default function Form(_props: FormProps) {}
|
fixed in main |
|
@itsjavi I tested the main branch again, so far no type errors and forwardRef is working great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us away from framework-agnostic types in the Story definition, but since the project is practically coupled with React, I think it's ok for now, until we focus on providing support for other frameworks.