Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeker bar doesn't show up (Android). [Fixed] #35

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

nomikeeper
Copy link

Due to the android support for overflowing components, seeker bar wasn't displaying itself as it supposed to. In order to fix that, created seeker View and styling for android and now it's working as it supposed to be.
Tested on both android and IOS, both was working fine.

react-native-cli: 2.0.1
react-native: 0.44.0

@RWOverdijk
Copy link
Contributor

@nomikeeper Just remove the flex on container altogether. That also fixes #36 :)

@nomikeeper
Copy link
Author

@RWOverdijk I've tried that and It certainly enables the seeker bar but the seeker bar handler didn't show up on android side because Android doesn't supports the object overflowing. I think controlling the video through seeker bar is essential functionality of the seeker bar. My fixing was focused on enabling the seeker bar on android side.
P.S: I found a problem in my previous pull request it not going to work as it supposed to be at the moment. I will fix them and going to make pull request again in case if you are in need of enabling the seeker handler on Android.

@RWOverdijk
Copy link
Contributor

Fair enough. I'm checking android later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants