Add spec test for the mountain car example #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasowski
changed the title
wasowski
requested changes
Nov 15, 2022
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Show resolved
Hide resolved
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Outdated
Show resolved
Hide resolved
| val positions = Gen.choose[Double] (-1.2, 0.5) | ||
| val velocities = Gen.choose[Double] (-1.5,1.5) | ||
| val negPos = Gen.choose[Double] (-1.2, -1.1) | ||
| val actions = Gen.oneOf (MountainCar.instances.enumAction.membersAscending) |
There was a problem hiding this comment.
instead val use given for actions
| // Tests | ||
|
|
||
| "Achieving goal state from state (0.0, 0.0) is impossible" in check { | ||
| forAll (actions) { a => |
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/symsim/examples/concrete/mountaincar/MountainCarSpec.scala
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| "moving to the left bound of position is possible" in check { | ||
| forAllNoShrink (velocities, actions) { (v, a) => |
There was a problem hiding this comment.
Actually, write for specific values of v, p, a to make the test more efficient.
wasowski
force-pushed
the
mountainCarSpec_branch
branch
from
cab5e53
to
623ef54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the step function that is corrected now. It was a swapped position and velocity values. #166