Use AddCookie method for greater compatibility #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems cannot deal correctly with cookies split across multiple Cookie: headers. From the AddCookie method documentation: > Per RFC 6265 section 5.4, AddCookie does not attach more than one Cookie header field. > That means all cookies, if any, are written into the same line, separated by semicolon.
itzg
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b1e8773 cookie manipulation logic was added which results in multiple cookies split across multiple
Cookie:headers.Some systems cannot deal correctly with cookies presented like this. On an NGINX + PHP-FPM setup, I observed that only the last cookie was available to the application!
This PR uses the AddCookie method of Request which avoids the issue:
Tested with grafana example, and after change, all cookies are passed in a single header.