Refactor/remove experimental decorators attribute validate #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes @Attribute and their corresponding @Validate in tests model
adds getter for attributes. needs to refactor relationships
fixes returned value, still needs to fix snapshot
Removes @Attribute and @validator decorators and fixes tests
dsalazar357
requested review from
jackiekircher,
jondayton and
dudeofawesome
dudeofawesome
approved these changes
Nov 29, 2022
jondayton
reviewed
Nov 30, 2022
jondayton
reviewed
Nov 30, 2022
removes getters from attributeDefinitions and uses static attrs
updates mockServer, factory and integration spec
uses new transformers in all specs
jondayton
suggested changes
Dec 2, 2022
optimises attrs picking from store
jondayton
approved these changes
Dec 2, 2022
dsalazar357
deleted the
refactor/remove-experimental-decorators-attribute-validate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes experimental decorators for
@attributesand@validateChanges
schema structurein model an store