remove decorators from relationships #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsalazar357
reviewed
Dec 15, 2022
jondayton
force-pushed
the
relationships
branch
from
9a54863
to
ce6115f
Compare
jondayton
force-pushed
the
relationships
branch
from
ce6115f
to
805b347
Compare
removes schema and fixes style bugs
updates docs in relationships file
jondayton
force-pushed
the
relationships
branch
from
805b347
to
60be13a
Compare
| @@ -939,45 +947,76 @@ class Store { | |||
| * @returns {Function} model constructor | |||
| */ | |||
| getKlass (type) { | |||
| return this.modelTypeIndex[type] | |||
| return this.models.find((model) => model.type === type) | |||
There was a problem hiding this comment.
Do we need modeltypeindex any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.