Unrequire logger

[saltycrys]

Crystal's Logger was required but never used in Invidious. Crystal 0.36.0
removed Logger in favor of Log.

Closes #1719.

[FireMasterK]

Shouldn't #1718 be reverted then?

[Perflyst]

I just tested but something is still broken with latest crystal, https://github.com/iv-org/invidious/runs/1800875655

In src/invidious/helpers/proxy.cr:76:7

 76 | @socket = nil
      ^
Error: instance variable @socket of HTTPClient was inferred to be Nil, but Nil alone provides no information
Error: Process completed with exit code 1.

[saltycrys]

I think pinning the Crystal version is a good thing. It's already pinned in the Dockerfile and dependencies might require a specific version.

I'll look into upgrading Invidious for Crystal 0.36.0 though.

[tenpura-shrimp]

Looks like this change in the release notes

https://crystal-lang.org/2021/01/26/crystal-0.36.0-released.html

A second breaking-change that affects C bindings is that a Crystal nil value is no longer translated to a null pointer value. Read more at #9872.

Edit: maybe not

[saltycrys]

It's crystal-lang/crystal#9543, see #1734.

[github-actions]

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.