ApiOnly CI

[kubo6472]

Closes #3871

[unixfox]

In my opinion I think it's better to build the image inside the same workflow: https://github.com/iv-org/invidious/blob/master/.github/workflows/container-release.yml

[kubo6472]

are you thinking another Dockerfile with this changed to include that apionly flag?

[kubo6472]

Hey, I did move the -Dapi_only from GH actions to the Dockerfiles. I suppose this can't be merged this way into master, right?

[SamantazFox]

If you put -Dapi_only in the container file, all builds will be API-only !

@unixfox I think it should be preferable to use make in the container. What do you think?
That way we could pass build args from docker directly to make, without all that if logic.

[unixfox]

If you put -Dapi_only in the container file, all builds will be API-only !

@unixfox I think it should be preferable to use make in the container. What do you think? That way we could pass build args from docker directly to make, without all that if logic.

Good idea, I have just been lazy to implement it ^^.

[unixfox]

So the goal is to use make in the dockerfile, make the Makefile options configurable then in github actions for each building step use the correct Makefile options for each kind of build (normal build, api only build, quic build).

[kubo6472]

Tried using make to build docker images, probably wrong, may be on the right track. Please do take a look. Thanks

[kubo6472]

Makefile wasn't in the container that was running the build.

[kubo6472]

Please do take a look when you'll have time. Thanks!

[unixfox]

Can you squash your commits?

[kubo6472]

Due to the merges I am unable to squash further. I hope this isn't an issue. I've made the changes that were last requested.

[unixfox]

You need to have just one commit remaining in https://github.com/iv-org/invidious/pull/3873/commits.
Check this guide: https://www.git-tower.com/learn/git/faq/git-squash

Or you can do it the ugly way, like I sometimes do. Copy somewhere else the changes that you made, remove the branch locally, create the same branch name and replace with the changes that you copied somewhere else.

[kubo6472]

best I could do, please let me know if it is okay now. for the future, I'm sure I'll prefer using branches like feature-apionly to not mess up the outdated master with the changes 😅

[SamantazFox]

That one still remains ^^
Can you also rebase your changes?

[kubo6472]

Should be good to go :) @SamantazFox

[github-actions]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[kubo6472]

If I take the energy to update this again, will it be merged?