-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thumbnails to dash #3987
Add thumbnails to dash #3987
Conversation
A little bump to draw the attention |
@unixfox @SamantazFox sorry for the ping, I'm not sure if this PR is in some sort of queue, or forgotten |
@iBicha yeah, sorry, I haven't been much active this past month (the PR backlog have been filling up :c). I'll try to review and test that soon! |
Thank you, I know finding time for FOSS is hard! Cheers |
@SamantazFox I'll refactor this after #4153 is merged |
Reflecting on this PR a bit, I will be closing this.
So there will always be quirks or limitations, and they will not be prioritized unless they can justify it. With that reasoning, I'll will be advocating to add things to Invidious that are not standards, or perhaps includes hacks and workarounds, so they fit the Roku OS. That does not sound right, that's why I'll be moving this piece to Playlet so I can cater to these cases (there are many differences between a standard dash player and Roku, including codecs, languages, containers and so on). Sucks, but it is what it is. Thank you! |
This is an attempt to close #3435
This allows seeking with a preview in Playlet
Here's what it looks like
It's not perfect, but it's a start
Note: I made sure that this is behind a flag (thumbnails) so that it does not change the behaviour for anyone who did not opt-in