Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnails to dash #3987

Closed
wants to merge 6 commits into from
Closed

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Jul 15, 2023

This is an attempt to close #3435

This allows seeking with a preview in Playlet
Here's what it looks like
It's not perfect, but it's a start

Note: I made sure that this is behind a flag (thumbnails) so that it does not change the behaviour for anyone who did not opt-in

thumbnails

@iBicha iBicha requested a review from a team as a code owner July 15, 2023 03:16
@iBicha iBicha requested review from unixfox and removed request for a team July 15, 2023 03:16
@github-actions github-actions bot added the stale label Aug 30, 2023
@syeopite syeopite removed the stale label Aug 30, 2023
@iv-org iv-org deleted a comment from github-actions bot Aug 30, 2023
@iBicha
Copy link
Contributor Author

iBicha commented Sep 6, 2023

A little bump to draw the attention

@iBicha
Copy link
Contributor Author

iBicha commented Sep 10, 2023

@unixfox @SamantazFox sorry for the ping, I'm not sure if this PR is in some sort of queue, or forgotten
Thanks

@unixfox unixfox requested review from SamantazFox and removed request for unixfox September 10, 2023 22:12
@SamantazFox
Copy link
Member

@iBicha yeah, sorry, I haven't been much active this past month (the PR backlog have been filling up :c). I'll try to review and test that soon!

@iBicha
Copy link
Contributor Author

iBicha commented Sep 17, 2023

@iBicha yeah, sorry, I haven't been much active this past month (the PR backlog have been filling up :c). I'll try to review and test that soon!

Thank you, I know finding time for FOSS is hard! Cheers

@iBicha iBicha marked this pull request as draft October 8, 2023 16:36
@iBicha iBicha marked this pull request as ready for review October 9, 2023 14:25
@iBicha
Copy link
Contributor Author

iBicha commented Oct 9, 2023

@SamantazFox I'll refactor this after #4153 is merged

@iBicha
Copy link
Contributor Author

iBicha commented Oct 14, 2023

Reflecting on this PR a bit, I will be closing this.
I'm trying to add DASH features primarily to support Playlet. I felt that the DASH generation belongs in Invidious, since it is a standard. But the more I dig into it, I discover limitations that are not part of the standard, and that are specific to Roku.
I asked Roku specifically about supporting tiles with different sizes (like in our case with the last page) and their response was in the lines of

...There are all kinds of variations in DASH. Based on needs we could implement those but this needs to be based on a business-related need (like loss or revenue and so on).

So there will always be quirks or limitations, and they will not be prioritized unless they can justify it.

With that reasoning, I'll will be advocating to add things to Invidious that are not standards, or perhaps includes hacks and workarounds, so they fit the Roku OS. That does not sound right, that's why I'll be moving this piece to Playlet so I can cater to these cases (there are many differences between a standard dash player and Roku, including codecs, languages, containers and so on).

Sucks, but it is what it is.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Thumbnails in DASH
3 participants