Minor correction to unsupported file extension error message #1177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
GitHub
PR contents
Description
Very small PR to improve the error message when a file extension is not supported, especially for double extensions.
We previously used
.stem
to output the name of the faulty file without extension in the terminal.This work great with single extension:
filename = image.png
:filename.stem
outputsimage
But not with double extensions:
filename = image.ome.tif
:filename.stem
outputsimage.ome
This PR now uses
.name
instead of.stem
and outputs the full filename with extension in the terminal, so:filename = image.png
:filename.stem
outputsimage.png
filename = image.ome.tif
:filename.name
outputsimage.ome.tif
Linked issues
No related issues in ivadomed.
It was raised in ADS PR629 where we use the same code to check file extensions.