Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add view and view_as to Cplx #6

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Add view and view_as to Cplx #6

merged 2 commits into from
Aug 15, 2020

Conversation

Rikorose
Copy link
Contributor

No description provided.

@ivannz
Copy link
Owner

ivannz commented Aug 12, 2020

thank you for your PR, @Rikorose ! Could you, please, add some unit tests to make sure Cplx mimics the behaviour of torch.Tensor.view (including error messages from bad shapes and the like)?

PS: thank you for pr #7. I merged it, so you'll need to rebase this branch atop the master.

@Rikorose
Copy link
Contributor Author

I added a unit test. Is this sufficient or can you think of more test cases that I should add?

@ivannz
Copy link
Owner

ivannz commented Aug 13, 2020

Great, @Rikorose ! thank you very much, looks good to
me. I will have a closer look at it on saturday.

@ivannz ivannz added the enhancement New feature or request label Aug 13, 2020
@ivannz ivannz merged commit 1fd41f7 into ivannz:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rikorose @ivannz