Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URWIDRepl.echod: two arguments or three? #6

Closed
mattjj opened this issue Apr 2, 2014 · 4 comments
Closed

URWIDRepl.echod: two arguments or three? #6

mattjj opened this issue Apr 2, 2014 · 4 comments

Comments

@mattjj
Copy link

mattjj commented Apr 2, 2014

On the current master, URWIDRepl.echod is defined to take one non-self argument, but in some places, like connect_ipython_kernel, it's called with two non-self arguments. That gave me this error (when trying to print another error):

Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/Current/bin/bipython", line 9, in <module>
    load_entry_point('bipython==0.1.2', 'console_scripts', 'bipython')()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bipython-0.1.2-py2.7.egg/bipython/__init__.py", line 1769, in main
    myrepl = URWIDRepl(event_loop, palette, interpreter, config)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bipython-0.1.2-py2.7.egg/bipython/__init__.py", line 651, in __init__
    self.ipython = self.connect_ipython_kernel()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bipython-0.1.2-py2.7.egg/bipython/__init__.py", line 708, in connect_ipython_kernel
    self.echod(":IPython " + s + " failed", "Info")
TypeError: echod() takes exactly 2 arguments (3 given)

What's the intended signature?

@mattjj
Copy link
Author

mattjj commented Apr 2, 2014

Btw, the error it was trying to print ended with

AttributeError: 'URWIDRepl' object has no attribute 'kc'

That was really a HumanDocReadingError because I hadn't run ipython console first, as per the README.

@chrisjordansquire
Copy link

This is the same error I ran into. I was using Ipython 2.

@ivanov
Copy link
Owner

ivanov commented Apr 3, 2014

@mattjj in your defense, that readme is kinda long though, and there are TWO of 'em. SPOILER ALERT! They all die at the end... ;)

@ivanov ivanov closed this as completed in 92ede39 Apr 3, 2014
@ivanov
Copy link
Owner

ivanov commented Apr 3, 2014

Thank you both for reporting, I think I've addressed this in master with a more informative error message on exit. It was already there, but only worked if you were running the latest IPython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants