-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version endpoint #2
Conversation
c2e5249
to
9088824
Compare
9088824
to
7ede4fc
Compare
7ede4fc
to
1ecb139
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in iver-wharf/wharf-provider-github#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging for requesting changes
50eaf6a
to
1c60e6f
Compare
Oh gosh I merged before having 2 reviewers... Got jinxed by $ gh pr status
Relevant pull requests in iver-wharf/wharf-api
Current branch
#2 Added version endpoint [feature/version-endpoint]
✓ Approved ✓ Up to date It did say approved. :( Will check closer next time |
version.go
withGET /import/github/version
endpointdeploy/update-version.sh
to updateversion.yaml
on Docker buildBUILD_*
build argsCHANGELOG.md
swag init
docs & usage as we're now relying on types from foreign packages (app.Version
)Based on iver-wharf/wharf-core#2
Closes #10