Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version endpoint #2

Merged
merged 1 commit into from
May 31, 2021
Merged

Added version endpoint #2

merged 1 commit into from
May 31, 2021

Conversation

applejag
Copy link
Contributor

@applejag applejag commented May 11, 2021

  • Added version.go with GET /import/github/version endpoint
  • Added deploy/update-version.sh to update version.yaml on Docker build
  • Updated main.go with metadata
  • Updated .wharf-ci.yml to populate BUILD_* build args
  • Updated CHANGELOG.md
  • Updated swag init docs & usage as we're now relying on types from foreign packages (app.Version)

Based on iver-wharf/wharf-core#2

Screenshot_2021-05-28_17-06-59

Closes #10

@applejag applejag added the enhancement New feature or request label May 11, 2021
@applejag applejag self-assigned this May 11, 2021
@applejag applejag added this to In progress in Backlog via automation May 11, 2021
@applejag applejag force-pushed the feature/version-endpoint branch 2 times, most recently from c2e5249 to 9088824 Compare May 11, 2021 13:02
@applejag applejag moved this from In progress to Review in progress in Backlog May 11, 2021
main.go Show resolved Hide resolved
Copy link
Contributor

@Pikabanga Pikabanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Pikabanga Pikabanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging for requesting changes

@applejag applejag marked this pull request as draft May 12, 2021 09:29
@applejag applejag marked this pull request as ready for review May 28, 2021 15:07
Backlog automation moved this from Review in progress to Reviewer approved May 31, 2021
@applejag applejag merged commit 79af59e into master May 31, 2021
Backlog automation moved this from Reviewer approved to Done May 31, 2021
@applejag applejag deleted the feature/version-endpoint branch May 31, 2021 07:41
@applejag
Copy link
Contributor Author

Oh gosh I merged before having 2 reviewers...

Got jinxed by gh CLI tool

$ gh pr status
Relevant pull requests in iver-wharf/wharf-api

Current branch
  #2  Added version endpoint [feature/version-endpoint]
  ✓ Approved ✓ Up to date

It did say approved. :( Will check closer next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Version endpoint
3 participants