-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version endpoint #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
force-pushed
the
feature/version-endpoint
branch
from
May 11, 2021 14:08
e5a28ff
to
b7050dc
Compare
applejag
force-pushed
the
feature/version-endpoint
branch
2 times, most recently
from
May 11, 2021 14:36
5296343
to
a292f0f
Compare
Pikabanga
reviewed
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in iver-wharf/wharf-provider-github#5
Pikabanga
suggested changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging for requesting changes
applejag
force-pushed
the
feature/version-endpoint
branch
from
May 28, 2021 14:50
a292f0f
to
1c1ecc0
Compare
Pikabanga
approved these changes
May 31, 2021
fredx30
approved these changes
May 31, 2021
This was referenced Jul 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version.go
withGET /import/github/version
endpointdeploy/update-version.sh
to updateversion.yaml
on Docker buildBUILD_*
build argsCHANGELOG.md
swag init
docs & usage as we're now relying on types from foreign packages (app.Version
)Based on iver-wharf/wharf-core#2
Closes #4