-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIN & GORM logging integration #11
Conversation
9136d90
to
7df879e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few typos and nits.
0bdbfab
to
aa57975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style seems fine to me.
Th PR description is missing both what and why. What problem does this solve? What does the integration do?
Updated desc |
aa57975
to
c15e255
Compare
Summary
Adds easy integration for Gin-Gonic & GORM with wharf-core's logging. See the _example_test.go files for how they're meant to be used, but here's the gist:
Motivation
GORM and Gin still has their built-in ways for logging, but allow you to add your own logger if you want to. These changes makes that integration easy, so with just a few lines then both GORM and Gin will use wharf-core/pkg/logger for logging instead of their own solutions, which will bring a more unified visual to our logs