Use debug instead of console.log, change successCalback position #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jason-hwang
commented
Apr 22, 2016
jason-hwang
commented
- Use debug instead of console.log.
- Change successCalback position, which should be called in self.server.close.
…led in server.close
| @@ -140,19 +140,19 @@ Scheduler.prototype.startServer = function(successCallback, failureCallback) { | |||
| var host = server.address().address; | |||
| var port = server.address().port; | |||
|
|
|||
| console.log('secc-scheduler listening at http://%s:%s', host, port); | |||
| debug('secc-scheduler listening at http://%s:%s', host, port); | |||
There was a problem hiding this comment.
it's good to use 'console.log' at this time.
'cos, user need to know what's going on
There was a problem hiding this comment.
oh, my mistake : ) I can apply next patch.
| }); | ||
|
|
||
| // Server connection event | ||
| server.on('connection', function (socket) { | ||
| // Add a newly connected socket | ||
| var socketId = self.nextSocketId++; | ||
| self.sockets[socketId] = socket; | ||
| console.log('socket', socketId, 'opened'); | ||
| debug('socket', socketId, 'opened'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.